Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebuilding for multiple target does not work with 6.0.1 #90

Open
Lesstat opened this issue May 24, 2024 · 2 comments · May be fixed by #91
Open

Prebuilding for multiple target does not work with 6.0.1 #90

Lesstat opened this issue May 24, 2024 · 2 comments · May be fixed by #91

Comments

@Lesstat
Copy link

Lesstat commented May 24, 2024

We use prebuildify to prebuild for the target environments that we use and execute it something like this:

prebuildify -t 18.20.3 -t 20.13.1 -t electron@29.4.0 -t electron@30.0.6

With version 5.0.1 this resulted in 3 prebuilds with the names:

  • node.abi108.node
  • node.abi115.node
  • electron.abi121.node
  • electron.abi123.node

After upgrading to 6.0.1 we only get 1 prebuild with the name: my-package-name.node. This means the prebuild will only work in some environments and error in others. Prebuildify still runs three builds but I assume only the last one is available in the builds folder. Platform is Windows if that matters.

@Totto16
Copy link

Totto16 commented May 26, 2024

This also happens on linux, and not with 5.0.1

It seems, that what happens is:

In 5.0.1 it is called ${runtime}.${version}.node where runtime is electron or node, version is the node_module_version

And in 6.0.1 it is called ${name}.node Where name is the package name

It seems that they added the name, and forgot to add the other tags to the final name 🤷🏼‍♂️

Totto16 added a commit to Totto16/prebuildify that referenced this issue May 27, 2024
- add test, that uses "real worlds scenario" by using really parsed options, not just artificially generated options
- to make this tests possible, I had to factor the function, that parses teh args out, and make a separate file
NorthernMan54 added a commit to homebridge/node-pty-prebuilt-multiarch that referenced this issue May 27, 2024
NorthernMan54 added a commit to homebridge/node-pty-prebuilt-multiarch that referenced this issue Jun 7, 2024
* Update to NAN 2.19.0 - better support for Electron 29

* feat: support node abi 127 (Node v22) (#43)

* update `README`

* feat: support node abi 127 (Node v22)

Fixes #42

---------

Co-authored-by: Ben <43026681+bwp91@users.noreply.github.com>
Co-authored-by: Northern Man <19808920+NorthernMan54@users.noreply.github.com>

* Build updates for warning messages

* Update Prepare prebuild environment.yml

* Update Prepare prebuild environment.yml

* Update Prepare prebuild environment.yml

* Update Prepare prebuild environment.yml

* Update Prepare prebuild environment.yml

* Update Prepare prebuild environment.yml

* drop older versions

* Fix MacOS Arm Build

* Update Prepare prebuild environment.yml

* Update Prepare prebuild environment.yml

* ModuleNotFoundError: No module named 'distutils'

* Reduce warning messages

* Update Prepare prebuild environment.yml

* Update Prepare prebuild environment.yml

* Update Prepare prebuild environment.yml

* Update dependencies

* Update Prepare prebuild environment.yml

* Rollback for this issue - prebuild/prebuildify#90

prebuild/prebuildify#90

* Update README.md

---------

Co-authored-by: Steffen Neubauer <stefreak@googlemail.com>
Co-authored-by: Ben <43026681+bwp91@users.noreply.github.com>
@Lesstat
Copy link
Author

Lesstat commented Jul 8, 2024

I just tested the fix in #91 and it worked as expected for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants