Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox Headers #7

Open
fvrrvg opened this issue May 7, 2024 · 1 comment
Open

Firefox Headers #7

fvrrvg opened this issue May 7, 2024 · 1 comment

Comments

@fvrrvg
Copy link

fvrrvg commented May 7, 2024

Hi there!

First off, thank you so much for your work here! I'm glad I was able to find it when I needed exactly what the package offers.

While building a project using it, I came across this behavior where Firefox isn't working as expected, while all Chromium-based browsers just work fine. After debugging, I realized that the issue lies in the function Proxy, as it expects the header 'Connection' to be 'Upgrade'. However, with Firefox, when connecting to a websocket, it uses the header 'keep-alive, Upgrade' instead, and that's what was causing the issue and kept returning without giving any errors.

I'd be more than happy to make a PR if you're okay with that. Just let me know!

@pretty66
Copy link
Owner

Sorry, I just saw this question now; if it is convenient for you, you can submit a PR and I will deal with it as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants