Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[p-tree] Distinguish between a drop on the nodes and a drop between the nodes #16170

Closed
Eiael opened this issue Aug 5, 2024 · 1 comment · Fixed by #16174
Closed

[p-tree] Distinguish between a drop on the nodes and a drop between the nodes #16170

Eiael opened this issue Aug 5, 2024 · 1 comment · Fixed by #16174
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add v18-port
Milestone
17.18.13

Comments

@Eiael
Copy link
Contributor

Eiael commented Aug 5, 2024

Describe the bug

It is impossible to distinguish a drop on a drop point between the nodes from a drop on a node. A specific drop restriction behavior can be defined by rewriting the allowDrop method, but this missing information is problematic.

Environment

Windows 11, Google Chrome

Reproducer

No response

Angular version

17.1.0

PrimeNG version

17.18.7

Build / Runtime

TypeScript

Language

TypeScript

Node version (for AoT issues node --version)

20.13.1

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@Eiael Eiael added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 5, 2024
@Eiael Eiael mentioned this issue Aug 6, 2024
Merged
@cetincakiroglu cetincakiroglu added this to the 18.0.0-rc.1 milestone Aug 8, 2024
@cetincakiroglu cetincakiroglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Type: New Feature Issue contains a new feature or new component request and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: New Feature Issue contains a new feature or new component request labels Aug 8, 2024
@kheos31
Copy link
Contributor

kheos31 commented Sep 25, 2024

Hello @cetincakiroglu, any news on the PR linked to this issue? I believed it would be already integrated according to the marked milestones.
Thanks and have a nice day!

@mertsincan mertsincan modified the milestones: 18.x, 17.18.13 Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add v18-port
Projects
None yet
Milestone
17.18.13
Development

Successfully merging a pull request may close this issue.

Add a boolean which indicates if the drop is in a drop point or a node Eiael/primeng
4 participants
@Eiael @mertsincan @cetincakiroglu @kheos31