From 2106f43362e808c0dc37e3b99da31dc78b4a4a6b Mon Sep 17 00:00:00 2001 From: KimiWu Date: Sun, 28 Jan 2024 11:01:01 +0900 Subject: [PATCH] chore: fix clippy and wasm error --- circuit-benchmarks/src/super_circuit.rs | 1 + zkevm-circuits/src/sig_circuit.rs | 7 ++++--- zkevm-circuits/src/sig_circuit/test.rs | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/circuit-benchmarks/src/super_circuit.rs b/circuit-benchmarks/src/super_circuit.rs index 450a912d940..e9868aabbea 100644 --- a/circuit-benchmarks/src/super_circuit.rs +++ b/circuit-benchmarks/src/super_circuit.rs @@ -89,6 +89,7 @@ mod tests { max_bytecode: 512, max_evm_rows: 0, max_keccak_rows: 0, + max_vertical_circuit_rows: 0, }; let (_, circuit, instance, _) = SuperCircuit::build(block, circuits_params, Fr::from(0x100)).unwrap(); diff --git a/zkevm-circuits/src/sig_circuit.rs b/zkevm-circuits/src/sig_circuit.rs index 1fd0236a804..0b433722091 100644 --- a/zkevm-circuits/src/sig_circuit.rs +++ b/zkevm-circuits/src/sig_circuit.rs @@ -18,7 +18,10 @@ mod utils; use crate::{ evm_circuit::{util::not, EvmCircuit}, keccak_circuit::KeccakCircuit, - sig_circuit::ecdsa::ecdsa_verify_no_pubkey_check, + sig_circuit::{ + ecdsa::ecdsa_verify_no_pubkey_check, + utils::{calc_required_advices, FpChip}, + }, table::{KeccakTable, SigTable}, util::{word::Word, Challenges, Expr, SubCircuit, SubCircuitConfig}, }; @@ -40,8 +43,6 @@ use halo2_ecc::{ FieldChip, }, }; - -#[cfg(any(feature = "test", test, feature = "test-circuits"))] pub(crate) use utils::*; use halo2_proofs::{ diff --git a/zkevm-circuits/src/sig_circuit/test.rs b/zkevm-circuits/src/sig_circuit/test.rs index 100ee237c5b..8a097d1e272 100644 --- a/zkevm-circuits/src/sig_circuit/test.rs +++ b/zkevm-circuits/src/sig_circuit/test.rs @@ -244,7 +244,7 @@ fn sign_with_rng( sign(randomness, sk, msg_hash) } -fn run(k: u32, max_verif: usize, signatures: Vec) { +fn run(k: u32, max_verif: usize, signatures: Vec) { // SignVerifyChip -> ECDSAChip -> MainGate instance column let circuit = SigCircuit:: { max_verif,