Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

Complete EIP 3860 in CREATE circuit for Shanghai compatibility #1458

Closed
KimiWu123 opened this issue Jun 6, 2023 · 2 comments
Closed

Complete EIP 3860 in CREATE circuit for Shanghai compatibility #1458

KimiWu123 opened this issue Jun 6, 2023 · 2 comments
Assignees
@KimiWu123
Labels
T-feature Type: new features
Milestone
Feature Completeness

Comments

@KimiWu123
Copy link
Contributor

KimiWu123 commented Jun 6, 2023 •
edited
Loading

Describe the feature you would like

More details can see #1430 (comment)

Reference: EIP 3860

Additional context

Support EIP 3860 in normal case (CREATE), error cases (covered in #1562) and deployment tx (begin_tx). See privacy-scaling-explorations/zkevm-specs#481 (comment) for more details
@KimiWu123 KimiWu123 added the T-feature Type: new features label Jun 6, 2023
@KimiWu123 KimiWu123 moved this to 🆕 Product Backlog Items in zkEVM Community Edition Jun 6, 2023
@KimiWu123 KimiWu123 mentioned this issue Jun 7, 2023
Merged
4 tasks
@KimiWu123 KimiWu123 moved this from 🆕 Product Backlog Items to Milestone Tasks in zkEVM Community Edition Jul 6, 2023
@KimiWu123 KimiWu123 added this to the Feature Completeness milestone Jul 6, 2023
@KimiWu123 KimiWu123 moved this from Milestone Tasks to 📋 Sprint Focus in zkEVM Community Edition Aug 17, 2023
@KimiWu123 KimiWu123 moved this from 📋 Sprint Focus to 🏗 In progress in zkEVM Community Edition Aug 28, 2023
@KimiWu123 KimiWu123 self-assigned this Aug 28, 2023
@KimiWu123
Copy link
Contributor Author

KimiWu123 commented Aug 28, 2023 •
edited
Loading

Wait for #1562 being merged.

begin_tx.rs and error cases(#1562) have covered EIP3860. The leftovers are normal case (CREATE) and gas uint overflow (which is #1526). So, this PR only takes care of normal case and will wait for #1562 being merged

@KimiWu123 KimiWu123 moved this from 🏗 In progress to 📋 Sprint Focus in zkEVM Community Edition Aug 28, 2023
@KimiWu123 KimiWu123 moved this from 📋 Sprint Focus to 🏗 In progress in zkEVM Community Edition Sep 11, 2023
@KimiWu123
Copy link
Contributor Author

The normal case was covered in #1430. See this snippet https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/1430/files#diff-66e8458ad6b55447e17de7f715e4395be943d682483be4a945b51f98a4cc50aeR156-R161

@KimiWu123 KimiWu123 moved this from 🏗 In progress to ✅ Done in zkEVM Community Edition Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KimiWu123 KimiWu123

Labels
T-feature Type: new features
Projects
zkEVM Community Edition
Status: ✅ Done
Milestone
Feature Completeness
Development

No branches or pull requests
1 participant
@KimiWu123