Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

testool issues #1622

Closed
lispc opened this issue Sep 22, 2023 · 1 comment · Fixed by #1630
Closed

testool issues #1622

lispc opened this issue Sep 22, 2023 · 1 comment · Fixed by #1630
Assignees
@ChihChengLiang
Labels
T-bug Type: bug

Comments

@lispc
Copy link
Collaborator

lispc commented Sep 22, 2023 •
edited
Loading

What command(s) is the bug in?

No response

Describe the bug

  1. Ignored_SkipTestDifficulty and Ignored_SkipTestBalanceOverflow not needed. They are related limitation of scroll l2 evm. I guess these tests should work well for standard evm.
  2. i noticed the html report only shows "circuit was not satisfied" without more details. I remembered previously detailed failure msg is shown on the web page?
  3. creationTxInitCodeSizeLimit_d1(invalid)_g0_v0 should be parsed as exception and return ok.
  4. skip precompile tests? since they are not implemented.. a lot of constrain failures.. At least the "MemoryOp writes for caller memory" is missing.
  5. why not use shanghai fork? https://github.com/privacy-scaling-explorations/zkevm-circuits/blame/69d0a63004487f9227906abcad36f840421b11aa/testool/src/utils.rs#L28

Concrete steps to reproduce the bug. If it's able reproduce via testool, please share test_id from jenkins report

No response
@lispc lispc added the T-bug Type: bug label Sep 22, 2023
@ChihChengLiang
Copy link
Collaborator

I can take this task.

@ChihChengLiang ChihChengLiang self-assigned this Sep 27, 2023
@ChihChengLiang ChihChengLiang moved this to 🏗 In progress in zkEVM Community Edition Sep 27, 2023
@ChihChengLiang ChihChengLiang mentioned this issue Sep 27, 2023
Merged
5 tasks
@ChihChengLiang ChihChengLiang linked a pull request Sep 27, 2023 that will close this issue
Address various testool issues #1630
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 28, 2023
@ChihChengLiang @ed255 @adria0
Address various testool issues (#1630)
190ff41 
### Description

- [x] `SkipTestDifficulty` and `SkipTestBalanceOverflow` should not be
ignored.
- [x] `creationTxInitCodeSizeLimit_d1(invalid)_g0_v0` should be parsed
as exception and return ok.
- Address this error`Exception(expected:false,
found:"TracingError(\"Failed to run Trace, err: Failed to apply
config.Transactions[0]: max initcode size exceeded: code size 49153
limit 49152\")")`
- [x]  skip precompile tests
- [x] Use shanghai fork
- [x] Fix "circuit was not satisfied." We report the first failure and
the total number of failures.

### Issue Link

#1622

### Type of change

Bug fix (non-breaking change which fixes an issue)

---------

Co-authored-by: Eduard S. <eduardsanou@posteo.net>
Co-authored-by: adria0.eth <5526331+adria0@users.noreply.github.com>
@ChihChengLiang ChihChengLiang moved this from 🏗 In progress to ✅ Done in zkEVM Community Edition Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ChihChengLiang ChihChengLiang

Labels
T-bug Type: bug
Projects
zkEVM Community Edition
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Address various testool issues privacy-scaling-explorations/zkevm-circuits
2 participants
@lispc @ChihChengLiang