Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

bug: precompile should be warm in begin_tx #1626

Closed
lispc opened this issue Sep 22, 2023 · 0 comments · Fixed by #1640
Closed

bug: precompile should be warm in begin_tx #1626

lispc opened this issue Sep 22, 2023 · 0 comments · Fixed by #1640
Assignees
@ChihChengLiang
Labels
T-bug Type: bug

Comments

@lispc
Copy link
Collaborator

lispc commented Sep 22, 2023

What command(s) is the bug in?

No response

Describe the bug

we set them to warm like this https://github.com/scroll-tech/zkevm-circuits/blob/7ddaf92b1f92dc8bcad9bd004457333b84e5e9d4/bus-mapping/src/evm/opcodes/begin_end_tx.rs#L140

Concrete steps to reproduce the bug. If it's able reproduce via testool, please share test_id from jenkins report

No response
@lispc lispc added the T-bug Type: bug label Sep 22, 2023
@ChihChengLiang ChihChengLiang mentioned this issue Oct 3, 2023
Merged
1 task
@ChihChengLiang ChihChengLiang linked a pull request Oct 3, 2023 that will close this issue
Add precompile contracts' addresses to the access list #1640
Merged
1 task
@ChihChengLiang ChihChengLiang self-assigned this Oct 3, 2023
@ChihChengLiang ChihChengLiang moved this to 👀 In review in zkEVM Community Edition Oct 3, 2023
github-merge-queue bot pushed a commit that referenced this issue Oct 5, 2023
@ChihChengLiang @adria0
Add precompile contracts' addresses to the access list (#1640)
ed866f0 
### Description

We upstream scroll's precompile handling in bus mapping so that the EVM
circuit warms the precompile addresses at the beginning of the
transaction.

### Issue Link

#1626

### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)

### Content

- Warm precompile addresses
- Fix some minor issues in StepRws offset and the Rws debugging
messages.

---------

Co-authored-by: adria0.eth <5526331+adria0@users.noreply.github.com>
@ed255 ed255 moved this from 👀 In review to ✅ Done in zkEVM Community Edition Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ChihChengLiang ChihChengLiang

Labels
T-bug Type: bug
Projects
zkEVM Community Edition
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add precompile contracts' addresses to the access list privacy-scaling-explorations/zkevm-circuits
2 participants
@lispc @ChihChengLiang