You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Asserting the current MPT witness generator's correctness is hard. The only path I see is through
MPTWG generates witnesses from Infura or Geth.
MPTWG dumps json files, which serves as test cases for the MPT circuit.
The MPT circuit reads json files and runs mock prover
We have completed step 1 of #1566, which ported MPTWG to this codebase. Now we are at step 2.
JSONs are only generated in the test run and passed directly to the circuit. We make sure the MPT circuit consumes the correct version of witness automatically.
But there's a problem, if the json is generated from a mainnet block, it might be better to store the json file, so that we don't depend on Infura on every test run.
But whether we decide to keep json files or not. It would be great to design for format for it for readability.
JSON format
The first thing to do is to reduce the space occupied by the bytes. We encode them in hex strings.
prettify the struct for readability.
Additional context
No response
The text was updated successfully, but these errors were encountered:
### Description
### Issue Link
#1658
### Type of change
Breaking change (fix or feature that would cause existing functionality
to not work as expected)
### Contents
- [x] Use proper Go libraries to dump the json files. This reduces the
number of serialization/deserialization codes and errors.
- [x] Regenerate JSON files.
- [x] Rewrite the parsing code in MPT circuit.
### How Has This Been Tested?
See if the new JSON format can be consumed by the MPT circuit and run
the test successfully.
Describe the feature you would like
Asserting the current MPT witness generator's correctness is hard. The only path I see is through
We have completed step 1 of #1566, which ported MPTWG to this codebase. Now we are at step 2.
But there's a problem, if the json is generated from a mainnet block, it might be better to store the json file, so that we don't depend on Infura on every test run.
But whether we decide to keep json files or not. It would be great to design for format for it for readability.
JSON format
Additional context
No response
The text was updated successfully, but these errors were encountered: