Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

[proof-chunk] implement uncompleted features in bus-mapping and refactor #1778

Closed
Tracked by #1498
hero78119 opened this issue Feb 22, 2024 · 0 comments · Fixed by #1785
Closed
Tracked by #1498

[proof-chunk] implement uncompleted features in bus-mapping and refactor #1778

hero78119 opened this issue Feb 22, 2024 · 0 comments · Fixed by #1785
Assignees
Labels
T-feature Type: new features

Comments

@hero78119
Copy link
Member

Describe the feature you would like

To addressed left issues from PR #1690

Additional context

No response

@hero78119 hero78119 added the T-feature Type: new features label Feb 22, 2024
@hero78119 hero78119 changed the title implement uncompleted features in bus-mapping and refactor [proof-chunk] implement uncompleted features in bus-mapping and refactor Feb 22, 2024
@hero78119 hero78119 moved this to 🏗 In progress in zkEVM Community Edition Feb 22, 2024
@hero78119 hero78119 self-assigned this Feb 29, 2024
hero78119 added a commit that referenced this issue Mar 1, 2024
…test (#1773)

### Content
Reported issues found on multi-chunk testing

- [x] refactor 1: simply chunking boundary judgement logic in
bus-mapping to ready for finish other incompleted features + avoid tech
dept in the future
- [x] add uncompleted logic in bus-mapping: chronological and by-address
rwtable not propagate pre-chunk last rw correctly.
- [x] edge case: deal with dummy chunk for real chunk less than desired
chunk in circuit params
- [x] allow zero limb diff in state_circuit lexicoordering => we allow
duplicated `rw_counter` in `padding`, and rely on permutation
constraints on by-address/chronological rw_table to avoid malicious
padding insert.
- [x] super_circuit/root_circuit tests adopt multiple chunk  

### Related Issue
To close
#1778
@ed255 ed255 linked a pull request Mar 7, 2024 that will close this issue
1 task
@ed255 ed255 moved this from 🏗 In progress to 👀 In review in zkEVM Community Edition Mar 7, 2024
@ed255 ed255 moved this from 👀 In review to ✅ Done in zkEVM Community Edition Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-feature Type: new features
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant