-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Casings #15
Labels
enhancement
New feature or request
Comments
Excellent suggestion! Hopefully this will be available for the next release. |
All the parameters are available into the same dictionary and the casings names have been changed for a better understanding. Additionally, a function pwptemp.input.info( ) was created to get information regarding all the parameters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Added a to-do task.
Today the model accepts an arbitrary 3 casings, and it is not straight forward to define them, as you have to give the shoe depths one place and the dimensions somewhere else.
I suggest you take away all the 9 (?) casing related properties, and replace them with one, "casings" which takes an array of any number of casings, defined by depth and diameters:
'casings': [{'od': num, 'id': num, 'md': num}, ...]
This array could be sorted by md for example, to make sure the casings are in the right order.
You would have to rewrite your code a bit to fit that change, but it would be a great benefit.
The text was updated successfully, but these errors were encountered: