-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove monkey-patching builtins #1535
Labels
Comments
jlu5
added a commit
that referenced
this issue
Jun 5, 2023
jlu5
added a commit
that referenced
this issue
Jul 1, 2023
jlu5
added a commit
that referenced
this issue
Jul 1, 2023
jlu5
added a commit
that referenced
this issue
Aug 12, 2023
progval
pushed a commit
that referenced
this issue
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This sort of hack is absolutely not future proof and makes it hard to track where code originates from.
I cloned all the supported repos in PluginDownloader to see how they are used:
dynamicScope
This is trivial to migrate but we can also just store a wrapped version in
__builtins__
that raises a big warning when you call it via that instead of the proper import.format
This one is used everywhere so maybe it's worth keeping. Though it's also a simple import to migrate, so having the builtin version warn about deprecation is also feasible.
force
No hits.
Only hits are comments, docs, helper params, or getops usage.
I think this one is safe to remove (once we update core, of course).
The text was updated successfully, but these errors were encountered: