Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encryption functions should be agnostic to encode_prefix VS salt #336

Open
coilysiren opened this issue Dec 1, 2017 · 1 comment
Open

encryption functions should be agnostic to encode_prefix VS salt #336

coilysiren opened this issue Dec 1, 2017 · 1 comment

Comments

@coilysiren
Copy link
Contributor

No description provided.

@coilysiren
Copy link
Contributor Author

Determining whether to use report. encode_prefix or report.salt should be a concern of the report model, and all encryption prefix generation logic needs to be moved to the report model. All the encryption focused functions should only take in a single argument, as opposed to taking in both salt and encode_prefix

@ktschap ktschap mentioned this issue Dec 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue336 ktschap/callisto-core
1 participant
@coilysiren