-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make map object accessible #52
Comments
This was for me - we just need a way to get at the object created here: https://github.com/sul-dlss/blacklight-maps/blob/master/app/assets/javascripts/blacklight-maps/blacklight-maps-browse.js#L24 There should be a standard way to do this for jQuery plugins, but I'd have to look into it. |
If we do this, we may want to refactor the plugin from jQuery style to Leaflet style for better integration with other Leaflet / Leaflet plugins http://leafletjs.com/2013/06/28/leaflet-plugin-authoring-guide.html |
👍 It may be that the proper way is a leaflet plugin and then define some data attributes that trigger the spawning of a "map," which sets data on that node. For instance, we've injected the map into our show view as well, and in doing so we've ripped out the generic javascript_tag initializer and written some jQuery code to trigger off a selector. It would have been nice to just have data attributes trigger it. |
Is there any progress being done on this issue? I am working on a project and I would love to be able to extend some of the functionality (i.e. add new controls, add new layers, etc). |
@ismail44 As far as I know no one is working on this. If you think you might be interested in taking it on, let me know. |
Sure... I cannot say how quickly it be completed, but I'll go ahead and On Fri, Dec 4, 2015 at 1:37 PM, Eben English notifications@github.com
|
No description provided.
The text was updated successfully, but these errors were encountered: