Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Bootstrap css from node_modules instead of CDN #144

Open
tamarinkeisari opened this issue Jul 1, 2024 · 2 comments
Open

Import Bootstrap css from node_modules instead of CDN #144

tamarinkeisari opened this issue Jul 1, 2024 · 2 comments

Comments

@tamarinkeisari
Copy link
Contributor

Feature Request: Importing Bootstrap CSS Locally
Description:

This feature request proposes modifying the project to import the Bootstrap CSS file directly from the node_modules directory. Currently, the project relies on a CDN link for Bootstrap, which might not be accessible in isolated environments without internet access.

Benefits:

  • Enables deployment in environments with restricted internet access.
  • Provides more control over the specific Bootstrap version used in the project.

Implementation:
Deleting the link to the CDN from public/index.html, adding import of bootstrap.min.css in src/index.tsx.

Related links:
https://react-bootstrap.netlify.app/docs/getting-started/introduction
@snazy
Copy link
Member

snazy commented Jul 1, 2024

Mind providing a PR?

@tamarinkeisari tamarinkeisari mentioned this issue Jul 3, 2024
Merged
snazy pushed a commit that referenced this issue Jul 10, 2024
@tamarinkeisari
Use bundled bootstrap.min.css (#145)
b2da1b8 
Import Bootstrap CSS Locally

Description: This pull request modifies the project to import the Bootstrap CSS file directly from the node_modules directory, replacing the current dependency on the CDN link.

Summary of Changes
This update addresses the feature request to enhance the project's ability to function in isolated environments without internet access by importing Bootstrap CSS locally. The following changes have been made:

    Remove CDN Link
    Local Bootstrap Import:
    Added an import statement for bootstrap.min.css in src/index.tsx.

we test it locally in it seems to run fine

Related issue:
#144
@snazy
Copy link
Member

snazy commented Jul 11, 2024

See #148

@snazy snazy closed this as completed Jul 11, 2024
@snazy snazy reopened this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snazy @tamarinkeisari