-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.0.40 causing interactive gui to not work from ipython console #1809
Comments
Which Python version are you using? |
Most likely this is caused by some changes that were done because We have to rethink this a bit. I think I'll see if I can come up with an PR this weekend. @jansopousek: Would you be willing to test, if I push an PR for both prompt_toolkit and IPython? cc: @Carreau |
This should fix it on the prompt_toolkit side: #1810 This should fix it on IPython's side: ipython/ipython#14241 Both fixes have to be published. |
We are using python 3.11. Thanks for fixing it up. It is not that straightforward for me to test those, since I don't have any of those packages installed from source. But by the code which I provided it should be pretty easy to replicate. |
As a workaround I released prompt_toolkit 3.0.41 earlier today, which detects whether it's being called from IPython and adjusts accordingly to avoid this bug. A fix on IPython's side should follow soon. |
I can confirm this issue also on Windows 11 using Python 3.11.4, IPython 8.17.2, |
…sion.run(). (#14241) See: prompt-toolkit/python-prompt-toolkit#1809 To summarize: - In prompt_toolkit, some changes were done to get rid of a deprecation warning related to the usage of `set_event_loop()` on Python 3.12. It looks like IPython did had a workaround for the deprecation warning, but Xonsh for instance did not. Now, the code that was fixed in prompt_toolkit breaks input hooks in IPython. - The right thing to do would be to accept the input hook as an argument in prompt_toolkit, which is what this PR does: prompt-toolkit/python-prompt-toolkit#1810 - For IPython, we have to do a similar change to pass it as an argument (this PR). It's not well tested (I'm not using IPython with inputhooks myself). I'm also not very familiar myself with IPython's code base. I think it requires some coordination. I'm not sure if there's a way to be backward compatible. I guess if I push a new prompt_toolkit version with the fix on my side, nothing will break, but input hooks will for sure not work on any Python version until this is merged. We should probably set the minimum prompt_toolkit version after merging this.
This and 8c60193 does not fix it for radian. Cross reference: randy3k/radian#446
@randy3k, please please consult with @jonathanslenders on what needs to be changed on radian's side.
|
When starting the qt apps from ipython console, those apps are not working properly. This can be reproduced by following code in the ipython console:
The plot window is opened but frozen, the qt app is not properly started
The text was updated successfully, but these errors were encountered: