Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(installation): Make provider dependencies optional for pip installation #1647

Closed
mathiaHT opened this issue Jan 3, 2023 · 3 comments
Closed
Labels
feature-request New feature request for Prowler.

Comments

@mathiaHT
Copy link

mathiaHT commented Jan 3, 2023

I use only aws as a cloud provider. So I dont perform test against azure but still the dependencies are all installed

Use of poetry extra feature to make azure and boto3 dependencies optional.

Then to install prowler it would be possible to do either

pip install prowler-cloud[all]
pip install prowler-cloud[aws]
pip install prowler-cloud[azure]
@mathiaHT mathiaHT added feature-request New feature request for Prowler. status/needs-triage Issue pending triage labels Jan 3, 2023
@mathiaHT mathiaHT changed the title feat(): make provider dependencies optional make provider dependencies optional Jan 3, 2023
@jfagoagas
Copy link
Member

Hi @mathiaHT thanks for the suggestion. We have in our roadmap the migration to use poetry and this is a really good idea.

@jfagoagas jfagoagas removed the status/needs-triage Issue pending triage label Jan 3, 2023
@toniblyx toniblyx changed the title make provider dependencies optional [Installation] Make provider dependencies optional for pip installation Jan 4, 2023
@toniblyx toniblyx changed the title [Installation] Make provider dependencies optional for pip installation feat(installation): Make provider dependencies optional for pip installation Jan 4, 2023
@toniblyx
Copy link
Member

toniblyx commented Feb 21, 2023

Hi @mathiaHT, as you can see, we have done some tests with Poetry extras and it didn't convince us, at the end of the day now we install aws or azure dependencies on every installation, that is not that much in terms of size so it is not a big deal. We will continue using the installer as it is so pip install prowler will install all needed dependencies for any supported provider (so far AWS and Azure). For better dependency management we are moving to Poetry to use only pyproject.toml. Thanks for your suggestion, we are closing this feature request.

@jfagoagas
Copy link
Member

Hello @mathiaHT we have created this feature request to keep track of it #4696. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature request for Prowler.
Projects
None yet
Development

No branches or pull requests

4 participants