Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Double Summons" #57

Open
Runkel79 opened this issue Mar 18, 2021 · 3 comments
Open

"Double Summons" #57

Runkel79 opened this issue Mar 18, 2021 · 3 comments

Comments

@Runkel79
Copy link

If there are 2 or more Warlocks using this Addon for summons it get's really chaotic because there are always double summons, it looks to me the Addon doesn't correctly (or maybe not fast enough) sync wich Warlock is summoning a raid member using the "Next" Button.

What's also kinda annoying, let's say i'm the first Warlock in the group doing summons, when another Warlock with SteaSummons joins the raid it will Broadcast HIS messages instead of mine. (For explanation, i customized all the Raid Messages so it's easier to everyone to understand what to do instead of being lazy and just leave the Addon on it's default settings) :)

Otherwise a must have for every Warlock Player

@prowley
Copy link
Owner

prowley commented Apr 8, 2021

The first problem seems to be when people with the addon are in a laggy place (like org on a popular raid night, or when a buff is about to drop).

The second problem is intentional, someone gets picked to do the messages, and I decided it was a bad idea to give people the ability to make others say something they themselves did not configure.

@Runkel79
Copy link
Author

Runkel79 commented Apr 8, 2021

At first, thank you very much for your response! (I saw too many incredible Addons fade away because the Author lost interest or just doesn't have the time for further development anymore.)

I think in the case of my friends and me we can exclude Lag as a problem, we usually only port Raid members to Raid instance entrances, Songflowers or the Darkmoon Faire. Not very crowded areas, it even happens when we do one of our Molten Core Pugs a Raid Instance barely anyone cares about anymore.

@prowley
Copy link
Owner

prowley commented Apr 21, 2021

So to explain my theory of the lag, I have to explain how the net code works, so bear with me. The addon limits the bandwidth that it puts out, and also needs to ensure things that need to happen once only happen once. The problem is: there are a bunch of people with the addon and the addons need to figure out who is going to control the group so that things that should happen once only happen once. So the Addons communicate to figure out who that should be, and that's not an easy problem so that every independent addon comes up with the same answer. Anyway, someone becomes the net leader - the one who gives out all the instructions, and repeats the current status etc. If that person happens to be in a laggy area (like org on Tuesday eve) then that will effect the status updates. At least that's my theory - an addon like this is super hard to test and debug past a certain point, and that's primarily why updates have slowed, I don't want to release something I can't test properly and then break everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants