HTTP validator API: beacon and account endpoints #13191
Conversation
james-prysm
added
Blocked
…ts on validator client
james-prysm
force-pushed
the
http-validator-beacon
branch
from
a15298c
to
34c6f62
Compare
|
|
||
| forward_RemoteSigner_Sign_0 = runtime.ForwardResponseMessage | ||
| ) | ||
| package ignore |
There was a problem hiding this comment.
hmm i'm not totally sure, we have a few other ones that are like this as well.
There was a problem hiding this comment.
🔥 delete it 🔥
Where did it come from? If running the pb update script put it here, then leave it, I guess. We don't want to manually undo things that the scripts are doing. If anything, we would want to understand why this is getting put here then fix it at the root of the problem
| httputil.HandleError(w, "Prysm Wallet not initialized. Please create a new wallet.", http.StatusServiceUnavailable) | ||
| return | ||
| } | ||
| pageSize := r.URL.Query().Get("page_size") |
There was a problem hiding this comment.
No need to do this in this PR, but one easier way to make this function more testable is to have the beginning parse out all the stuff from the URL queries and request into some pure Go struct and then have an inner function that takes in all that validated data. This way, you can write your tests using more pure business logic instead of having to mock requests and urls, and separate test out the validation of inputs
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
|
|
||
| // Handler serves web requests from the bundled site data. | ||
| // DEPRECATED: Prysm Web UI and associated endpoints will be fully removed in a future hard fork. |
There was a problem hiding this comment.
Probably want to leave this deprecation?
There was a problem hiding this comment.
i can add it back
| // List of 48 byte, BLS12-381 validating public keys. | ||
| repeated bytes validating_public_keys = 2; | ||
| } | ||
|
|
||
| // SignRequest is a message type used by a keymanager | ||
| // as part of Prysm's accounts v2 implementation. | ||
| message SignRequest { |
There was a problem hiding this comment.
It looks like you can also delete SignRequest and SignResponse
There was a problem hiding this comment.
it's still used in the code right now even though the remote is not. you can do a search on the type
What type of PR is this?
Other
What does this PR do? Why is it needed?
migrates web endpoints from gRPC to REST validator.
auth endpoint
/v2/validator/initializeGETvalidator endpoints
/v2/validator/accountsGET/v2/validator/accounts/backupPOST/v2/validator/accounts/voluntary-exitPOSTbeacon endpoints
/v2/validator/beacon/statusGET/v2/validator/beacon/participation/v2/validator/beacon/summaryGET/v2/validator/beacon/validatorsGET/v2/validator/beacon/balancesGET/v2/validator/beacon/queue/v2/validator/beacon/peersGETUpdates webui site_data to v2.0.5
Cleanup
Tested with updated web ui
Which issues(s) does this PR fix?
part of #13041
BLOCKED BY WEBUI RELEASE AND PR prysmaticlabs/prysm-web-ui#249Other notes for review