-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please update your Dockerfile to not use a hardcoded 1000 uid #258
Comments
That's the standard of node:alpine. But feel free to make some suggestions |
Yes. That's why I'm suggesting to do the same as linuxserver does. (https://github.com/linuxserver/docker-baseimage-alpine/blob/master/root/etc/s6-overlay/s6-rc.d/init-adduser/run)
or change the uid/gid of use node to the one provided in the env variables, for ex.:
The last one of course assumes that the numbers given through env are available in the image itself, so probably the first one is safer to use. |
If you like prep a pr |
Using id 1000 is very restrictive.
Would be a tons better if one could just give the uid/gid through env variables like what linuxserver.io does:
https://docs.linuxserver.io/general/understanding-puid-and-pgid
The text was updated successfully, but these errors were encountered: