Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple image collection actions (like export) #29

Open
3 of 10 tasks
jywarren opened this issue Jan 14, 2015 · 11 comments
Open
3 of 10 tasks

multiple image collection actions (like export) #29

jywarren opened this issue Jan 14, 2015 · 11 comments

Comments

@jywarren
Copy link
Member

jywarren commented Jan 14, 2015

Part 1: -- this part is done.
This is becoming higher priority now, and would at most basic, include the ability to select and display as selected, multiple images.

Part 2: -- -- this part is done.
We should be able to return an array of selected images, and to perform actions using their collected image URLs or other properties.

Part 3: -- this part is done.
Eventually we should consider a menu for the manipulation of image collections, for example initiating an export. This relates to publiclab/mapknitter#326, the new MapKnitter Exporter UI, but could also be used for simple things like dragging a group of images together.

Part 4: -- Open to claim
Get all actions available in the single image interface working in the collection interface:

  • Export
  • Delete
  • ToggleTransparency
  • Restore
  • ToggleOutline
  • ToggleRotateScale
  • ToggleScale
  • ToggleRotate
  • EnableEXIF
  • ToggleLock
@jywarren jywarren changed the title multiple image selection, someday multiple image selection, image collection actions Feb 18, 2019
@sashadev-sky
Copy link
Member

claiming this!

@sashadev-sky
Copy link
Member

@jywarren hey just wanted to provide a status update here! Working on this and hoping to open a pull request tonight. Thank you

@sashadev-sky sashadev-sky mentioned this issue Feb 26, 2019
4 tasks
@jywarren
Copy link
Member Author

Amazing!!!!

@sashadev-sky sashadev-sky changed the title multiple image selection, image collection actions multiple image collection actions Mar 31, 2019
@sashadev-sky
Copy link
Member

@jywarren I updated this issue a little please feel free to revert it if you think it shouldn't be updated that way

@jywarren jywarren changed the title multiple image collection actions multiple image collection actions (like export) Apr 1, 2019
@jywarren
Copy link
Member Author

jywarren commented Apr 1, 2019

OK! We've ironed out the input format for both the Ruby and JS based exporters, documented here:

publiclab/mapknitter-exporter-sinatra#1 (comment)

And we'll also need some glue function to convert that into the JS-specific format here (although we can do that as a follow-up step!):

publiclab/image-sequencer-app#6 (comment)

This is all coming together!

@jywarren
Copy link
Member Author

jywarren commented Apr 1, 2019

We could aim for a function that outputs the basic JSON format in publiclab/mapknitter-exporter-sinatra#1 (comment), called collection.getExportJson()?

@jywarren
Copy link
Member Author

jywarren commented Apr 1, 2019

This would eventually be replaced/superceded by a fuller Export UI in React that @sashadev-sky has explored!

@jywarren
Copy link
Member Author

jywarren commented Apr 1, 2019

This is great. The new class -- was it FeatureCollection? -- is there an accessor function like featureCollection.getFeatures that would return an array we could iterate over?

@sashadev-sky
Copy link
Member

Class is called L.DistortableCollection. The Leaflet way of doing this is this.eachLayer(function(layer) { .... });. Not entirely convenient so I can save create quick PR for accessor function. Going to start the project first, though. Does that work?

@jywarren
Copy link
Member Author

jywarren commented Apr 5, 2019

Yeah, perfect!!!

@sashadev-sky
Copy link
Member

@jywarren made some updates here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants