Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiExport follow-ups (just docs now) #316

Closed
3 of 5 tasks
sashadev-sky opened this issue Jul 2, 2019 · 15 comments · Fixed by #385
Closed
3 of 5 tasks

MultiExport follow-ups (just docs now) #316

sashadev-sky opened this issue Jul 2, 2019 · 15 comments · Fixed by #385

Comments

@sashadev-sky
Copy link
Member

sashadev-sky commented Jul 2, 2019

follow-ups to #314:

  • show a spinner, and hide it when complete! pending: hide when completes
    • loader UI: considering for now just adding animated SVG loader icon to replace Export icon during load
  • prompt('Choose a scale in real-world centimeters per pixel, or click OK to use our best guess. Keep this window open to wait for your export to complete.', this._getAvgCmPerPixels()) (i think?) to prompt for a scale, but default to the average size?
  • open an issue for the "use the updated status_url value" which i tried to implement but it's not working. We should rejigger the section of code above that tries to match "complete" and the new JSON address. I think if we fix it, things will run a lot smoother!
  • and then MK integration!
  • Move documentation from Refactor getStatusJson #310 in once figure out how to expose the startExport method or confirm working well enough for API exposure
@sashadev-sky
Copy link
Member Author

@jywarren

@jywarren
Copy link
Member

jywarren commented Jul 2, 2019

Awesome! Also linking to publiclab/mapknitter#756 Insert custom updater function into Leaflet.DistortableImage for displaying export status

@jywarren
Copy link
Member

Linking from #203 too - looking great!

@jywarren
Copy link
Member

We can check off Spinner too, but I'm actually not seeing it on http://mapknitter-stable.laboratoriopublico.org/maps/test6/edit -- do you know why?

Aha - http://mapknitter-stable.laboratoriopublico.org/assets/leaflet-distortableimage/package.json currently shows 0.4.3 - let me update that!

@jywarren
Copy link
Member

OK, I ran sudo yarn install and moved /public/lib so it should be defaulting to /node_modules/, but it's still showing 0.4.3, so I'm going to restart the container to be sure it flushes any caching.

@jywarren
Copy link
Member

Also deleted the /assets/* dir to get it to correctly show 0.7.7 - now it's showing correctly, so I'll restart the container again.

@jywarren
Copy link
Member

We'll look here to test once it's rebuilt: http://mapknitter-stable.laboratoriopublico.org/maps/test6/edit

@jywarren
Copy link
Member

Hmm. Error. Looking it up!

@jywarren
Copy link
Member

Moving to publiclab/mapknitter#1042 for unrelated issue...

@jywarren
Copy link
Member

OK we are at 0.7.7 now in stable, so now, i think we need to stop overriding the default updater so that the new default (with the spinner) can start appearing?

Ref: #385

@jywarren
Copy link
Member

jywarren commented Dec 4, 2019

Now looking at publiclab/mapknitter#1124 to get this working with v0.8.7!

@jywarren
Copy link
Member

jywarren commented Dec 4, 2019

Yay publiclab/mapknitter#1126 !

We do need docs for this type of exporting, however!

@jywarren jywarren changed the title MultiExport follow-ups MultiExport follow-ups (just docs now) Dec 4, 2019
@jywarren
Copy link
Member

jywarren commented Dec 4, 2019

Especially for example how to switch between these two distinct cloud-based export systems:

@sashadev-sky
Copy link
Member Author

@jywarren for now I opened #470

@jywarren
Copy link
Member

jywarren commented Dec 5, 2019

Closing this in favor of #474 !

@jywarren jywarren closed this as completed Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants