Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CONTRIBUTING file #31

Closed
ryzokuken opened this issue Jun 11, 2017 · 9 comments
Closed

Add a CONTRIBUTING file #31

ryzokuken opened this issue Jun 11, 2017 · 9 comments

Comments

@ryzokuken
Copy link
Member

Add a CONTRIBUTING markdown file, shift the current contribution information from the README to this file, add information about how to name branches and everything, general guidelines regarding contributing to the project. Also, this file would be the most appropriate place to include the content to be added under #11.

Link this file to the README.

@ryzokuken
Copy link
Member Author

@jywarren what do you think about this one?

@jywarren
Copy link
Member

Well, I think the README can be quite long before this is needed, and it's great for it to be all in one place. So maybe we could wait on this until the README gets really really long?

@ryzokuken
Copy link
Member Author

@jywarren sure, sounds good.

@amitsin6h
Copy link
Member

@jywarren @ryzokuken can I work on this as my first contribution to PublicLab

@ryzokuken
Copy link
Member Author

ryzokuken commented Feb 18, 2018 via email

@amitsin6h
Copy link
Member

@ryzokuken what I understand from the issue is that we need to create a CONTRIBUTING .md file. but what things I have to write in the file.

@ryzokuken
Copy link
Member Author

Try looking at a few CONTRIBUTING.md files, especially the one we use at plots2. We'd basically need resources for new contributors in there. Make a PR with a dummy file and we could discuss the specifics inside that PR.

Thanks.

@amitsin6h
Copy link
Member

amitsin6h commented Feb 18, 2018

@ryzokuken could you please review the PR #94

@grvsachdeva
Copy link
Member

@ryzokuken @jywarren can I close this one as #94 seems to solve this issue? Thanks!

@jywarren jywarren closed this as completed Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants