Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Geocode tool back into new Capture interface, next steps #848

Closed
Tracked by #801
Georjane opened this issue Jan 14, 2022 · 6 comments · Fixed by #851
Closed
Tracked by #801

Port Geocode tool back into new Capture interface, next steps #848

Georjane opened this issue Jan 14, 2022 · 6 comments · Fixed by #851
Assignees

Comments

@Georjane
Copy link
Collaborator

Georjane commented Jan 14, 2022

@jywarren and @Tlazypanda
I think I will be picking up this issue next from publiclab/spectral-workbench.js#265

thank you

@Georjane
Copy link
Collaborator Author

Hi @Tlazypanda @TildaDares @jywarren 👋🏽

I was able to upload my first spectrum today locally.
I was trying to test the functionality of the geocoding tool on the old capture interface to compare it with the new capture/v2 version.
But I realized from this comment here that geocoding of the spectrum doesn't work anymore.
Please I would like to understand exactly what the geocode button is expected to do. Thank you
image

@Georjane
Copy link
Collaborator Author

I was also facing the error below when I added the geocode button from the old capture interface to the new capture v2. I tried debugging but to no avail. 😞
image

@Tlazypanda
Copy link
Collaborator

Hey @Georjane the Geocode part not working is what we are discussing on the call - the part where I mentioned that the params are not getting saved correctly on to the backend which is why it stopped working. Hence it's not included in the second version so we need to add it and get it working ✨

This error suggests that data variables passed as an argument here is actually nil, can you log the data variable here reference - https://stackoverflow.com/questions/57197682/in-decode64-undefined-method-unpack1-for-nilnilclass-nomethoderror

@jywarren
Copy link
Member

I believe the geocode button requests a location from the browser API for location, then it tries to attach it to the form using hidden inputs with ID #lat and #lon:

Hope that helps! It uses a callback so the code is a little tangled, but it's not too long!

@Georjane
Copy link
Collaborator Author

Hey @Georjane the Geocode part not working is what we are discussing on the call - the part where I mentioned that the params are not getting saved correctly on to the backend which is why it stopped working. Hence it's not included in the second version so we need to add it and get it working ✨

This error suggests that data variables passed as an argument here is actually nil, can you log the data variable here reference - https://stackoverflow.com/questions/57197682/in-decode64-undefined-method-unpack1-for-nilnilclass-nomethoderror

Hi @Tlazypanda
please i have difficulties understanding this line of code $('#geotag').val('true'!=$('#geotag').val())
Thank you!

@jywarren
Copy link
Member

jywarren commented Jan 19, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants