Chat connect/disconnect callbacks

[manfe]

Sorry to tag you directly piotr-suwala

But this is something really urgent.

The current implementation of connect on channel entity at least for me is not working as expected.

  /*
   * Streaming messages
   */
  connect(callback: (message: Message) => void) {
    const listener = {
      message: (event: MessageEvent) => {
        if (event.channel !== this.id) return
        const getMessageResponseBody =
          this.chat.config.customPayloads.getMessageResponseBody || defaultGetMessageResponseBody
        if (getMessageResponseBody(event).type !== "text") return
        callback(Message.fromDTO(this.chat, event))
      },
    }

    const removeListener = this.chat.addListener(listener)
    const unsubscribe = this.chat.subscribe(this.id)

    return () => {
      removeListener()
      unsubscribe()
    }
  }

export function defaultGetMessageResponseBody(messageParams: MessageDTOParams) {
  if (typeof messageParams.message === "string") {
    return {
      type: MessageType.TEXT,
      text: messageParams.message,
      files: [],
    }
  }
  return messageParams.message
}

Adding some debugs to defaultGetMessageResponseBody function:

    console.debug("e.message =>", e.message)
    console.debug("typeof e.message =>", typeof e.message)
    console.debug(`"string" == typeof e.message =>`, "string" == typeof e.message);

I am getting:

index.es.js:260: e.message => {text: 'example', timetoken: 1728918366738}
index.es.js:261: typeof e.message => object
index.es.js:262: "string" == typeof e.message => false

Hence, all my text messages it's returning on line:

return messageParams.message

that it's an object and do not include type property that is expected in this check on connect method:

if (getMessageResponseBody(event).type !== "text") return

[manfe]

To unblock me I am removing the line

if (getMessageResponseBody(event).type !== "text") return

So I can receive all messages regardless the type of it

[piotr-suwala]

Hello @manfe

Can you construct your own "getMessageResponseBody" as in this test? https://github.com/pubnub/js-chat/blob/master/lib/tests/message.test.ts#L1656

Something like:

Chat.init({
  customPayloads: {
    getMessageResponseBody: (messageParams: MessageDTOParams) => {
            return {
              text: messageParams.message.text,
              type: MessageTypes.Text,
              files: messageParams.message.body.files,
            }
          },
  }
})

[manfe]

That worked, thanks!