Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Remove missing pin warnings #327

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

colluca
Copy link
Contributor

@colluca colluca commented Dec 11, 2023

Corrects some missing pin warnings raised by Verilator 4.110.

@colluca colluca requested review from bluewww and micprog February 16, 2024 08:26
Copy link
Member

@micprog micprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SamuelRiedel
Copy link
Member

Is there anything preventing us from merging this? I was about to open the same PR since this fixes the compilation of MemPool with the current AXI version. 🚀

Copy link
Contributor

@bluewww bluewww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@micprog micprog merged commit f98f5ad into master Feb 27, 2024
3 checks passed
@micprog micprog deleted the fix/missing-pin-warnings branch February 27, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants