Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lleone/pmu #40

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Lleone/pmu #40

merged 1 commit into from
Sep 26, 2024

Conversation

Lore0599
Copy link

PMU Cluster Management

This PR introduces the necessary logic to handle power management controls for the clusters. To integrate the UPF files, some logic ports and signals have been added to the RTL to drive Isolation Cells, Power Switches, Retention, etc.

Added - HW

Ports

  • pmu_rst-cluster: Control signals to reset all clusters independently. These reset signals are driven by the PMU controller when power strategies need to be applied. Otherwise, they can use the same reset signal as the rest of the system.
  • pmu_iso_en/ack: These control signals are used by the PMU controller to isolate or un-isolate the cluster interface.

Logic

  • chimera_clu_domain/axi_isolate: At each AXI interface between clusters and the rest of the SoC, isolation strategies must be applied. Typically, simple isolation cells can be inserted through the UPF description. However, AXI ports require more complex isolation logic to handle in-flight transactions and responses. As a result, these ISO cells are omitted from the UPF and explicitly inserted in the RTL.

@Lore0599 Lore0599 requested a review from Scheremo September 23, 2024 07:04
@Lore0599 Lore0599 changed the base branch from main to devel September 23, 2024 07:04
Copy link
Collaborator

@Scheremo Scheremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks largely okay to me!

hw/chimera_clu_domain.sv Outdated Show resolved Hide resolved
hw/chimera_clu_domain.sv Outdated Show resolved Hide resolved
hw/chimera_top_wrapper.sv Show resolved Hide resolved
@Lore0599 Lore0599 force-pushed the lleone/pmu branch 2 times, most recently from c558762 to 099b844 Compare September 25, 2024 16:30
@Lore0599 Lore0599 requested a review from Scheremo September 25, 2024 17:04
Copy link
Collaborator

@Scheremo Scheremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment, then I'm happy :)

hw/chimera_pkg.sv Outdated Show resolved Hide resolved
@Lore0599 Lore0599 requested a review from Scheremo September 26, 2024 15:27
Copy link
Collaborator

@Scheremo Scheremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

 - Add ports for PMU cluster control signals.
 - Add rst signals for each external cluster, driven by the PMU controller.
 - Add AXI isolation at the cluster interface and control ports for isolation.
@Lore0599 Lore0599 merged commit 460e295 into devel Sep 26, 2024
6 checks passed
@Lore0599 Lore0599 deleted the lleone/pmu branch September 26, 2024 16:11
sermazz pushed a commit that referenced this pull request Oct 23, 2024
- Add ports for PMU cluster control signals.
 - Add rst signals for each external cluster, driven by the PMU controller.
 - Add AXI isolation at the cluster interface and control ports for isolation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants