From c96d46a27008fc54ccc0b40bceb9db9607dfb370 Mon Sep 17 00:00:00 2001 From: Samuel Riedel Date: Tue, 14 Nov 2023 15:11:46 +0100 Subject: [PATCH] [github] Add codeowners and update the contributor's guidelines --- .github/CODEOWNERS | 2 +- CONTRIBUTING.md | 6 ++++-- CONTRIBUTORS.md | 2 ++ 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 92b37f7dc..8763b9b5d 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,2 +1,2 @@ # Global owners -* @SamuelRiedel @suehtamacv +* @SamuelRiedel @suehtamacv @mbertuletti @sermazz @yichao-zh diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 318ecfe0f..1ee7ba92d 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -12,8 +12,8 @@ please find some of the most important points below. * Changes should only be made via pull request, with review. A pull request will be committed by a "committer" (an account listed in `CODEOWNERS`) once it has had an explicit positive review. -* Make sure you update the [CHANGELOG](CHANGELOG.md) when submitting a MR. -* When creating your first MR, enter your name in the [CONTRIBUTORS](CONTRIBUTORS.md) +* Make sure you update the [CHANGELOG](CHANGELOG.md) when submitting a PR. +* When creating your first PR, enter your name in the [CONTRIBUTORS](CONTRIBUTORS.md) list in alphabetical order. * When changes are restricted to a specific area, you are recommended to add a tag to the beginning of the first line of the commit message in square @@ -23,6 +23,8 @@ please find some of the most important points below. license without discussing first. * If a relevant bug or tracking issue exists, reference it in the pull request and commits. +* When not working on your own fork, please prefix your branch with your username + to keep the branches organized. I.e., "myname/amazing-feature" ## Git Considerations diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md index 35d800382..c2b743ec8 100644 --- a/CONTRIBUTORS.md +++ b/CONTRIBUTORS.md @@ -11,6 +11,8 @@ Thanks to all. * Luca Rufer * Marc Gantenbein * Marco Bertuletti +* Matheus Cavalcante * Philip Wiese +* Samuel Riedel * Sergio Mazzola * Yichao Zhang