Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add esc command to (at least) pulumi/pulumi image #175

Open
MitchellGerdisch opened this issue Nov 22, 2023 · 2 comments
Open

Add esc command to (at least) pulumi/pulumi image #175

MitchellGerdisch opened this issue Nov 22, 2023 · 2 comments
Labels
kind/enhancement Improvements or new features

Comments

@MitchellGerdisch
Copy link

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Pulumi deploy uses the pulumi/pulumi image by default.
It would be useful to have the Pulumi esc command installed on the image so it is available for things like prerun commands that use esc env run

Affected area/feature

@MitchellGerdisch MitchellGerdisch added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Nov 22, 2023
@justinvp justinvp removed the needs-triage Needs attention from the triage team label Nov 22, 2023
@pgavlin
Copy link
Member

pgavlin commented Jun 17, 2024

I'd suggest adding this to pulumi/pulumi-base

@zacdirect
Copy link

zacdirect commented Oct 30, 2024

I'm considering contributing to this and it looks like it might be a fairly substantial change from the workflows, CI, and finally the images themselves. To avoid a lot of back and forth on the PR I was wondering if you had thoughts on whether this should be an additional top-level variable next to pulumi_version, and if so, if you could offer some insight into the events that appear to be defaulting the existing pulumi version ENV variables.

I assume this is typically triggered via an event hook from upstream pulumi SDK changes. If so, could you offer context or guidelines on replicating that from an upstream ESC pipeline?

Lastly, if it would be desired to replicate event hooks, top level variables, environment variable defaults all for ESC... it seems like it might be a good time to rename the existing 'pulumi_version' to 'pulumi_iac_version' so the new variables and defaults could be 'pulumi_esc_version' now that the products are GA and more differentiated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

4 participants