The SDKv2 Bridge swallows resource init errors when run under PlanResourceChange

[VenelinMartinov]

What happened?

Under PlanResourceChange, the SDKv2 bridge incorrectly returns just an error to the engine in cases where the resource has been partially initialized. It should instead return both the error and the partial state, including the ID so that the engine can save the resource and re-attempt to update it on the next up.

References:

PRC:

pulumi-terraform-bridge/pkg/tfshim/sdk-v2/provider2.go

Line 350 in 03b9498

resp, err := p.server.ApplyResourceChange(ctx, t, ty, cfg, st, pl, priv, meta)

non-PRC:

pulumi-terraform-bridge/pkg/tfshim/sdk-v2/provider.go

Line 130 in 180b924

state, diags := r.Apply(ctx, state, diffFromShim(d), p.tf.Meta())

Discovered in pulumi/pulumi-gcp#2700

Example

Discovered in pulumi/pulumi-gcp#2700

Output of pulumi about

.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

[flostadler]

Causes pulumi/pulumi-aws#4759

[pulumi-bot]

This issue has been addressed in PR #2695 and shipped in release v3.97.0.

[iwahbe]

This change had to be reverted.

[pulumi-bot]

This issue has been addressed in PR #2713 and shipped in release v3.98.0.