Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement autonaming configuration protocol #2722

Closed
Tracked by #16188
mikhailshilkov opened this issue Dec 11, 2024 · 1 comment · Fixed by #2675
Closed
Tracked by #16188

Implement autonaming configuration protocol #2722

mikhailshilkov opened this issue Dec 11, 2024 · 1 comment · Fixed by #2675
Assignees
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone

Comments

@mikhailshilkov
Copy link
Member

mikhailshilkov commented Dec 11, 2024

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Implement the bridge part of pulumi/pulumi#1518. See pulumi/pulumi#17592 for the full design.

In short, pulumi/pulumi#17810 introduced the protobuf changes required for the provider-side implementation. With those, a provider can:

  • Declare that it supports autonaming configurations with a response flag in Configure
  • Accept two extra properties in CheckRequest: a proposed name and a mode to apply it

We need to implement autonaming configuration for all bridged providers. The bridge should pass the configuration from CheckRequest all the way down to the autonaming module. The module itself will be able to understand the modes and use the proposed name appropriately. Once a bridged provider upgrades its bridge version, autonaming configuration should highlight in it autonamically.

@mikhailshilkov mikhailshilkov added the kind/enhancement Improvements or new features label Dec 11, 2024
@mikhailshilkov mikhailshilkov self-assigned this Dec 11, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Dec 11, 2024
@mikhailshilkov mikhailshilkov removed the needs-triage Needs attention from the triage team label Dec 11, 2024
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Dec 12, 2024
@mikhailshilkov mikhailshilkov added this to the 0.114 milestone Dec 12, 2024
@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #2675 and shipped in release v3.98.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants