You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sometimes it happens that stuff runs on legacy platforms for reasons. The code in https://github.com/puppetlabs/puppetlabs-java/blob/main/manifests/init.pp#L97-L106 prevents the use of the module on unsupported platforms. This pattern is quite unique to this module. For example it prevents the use of the same module on Debian 9 (supported until v10.x.x) and Debian 12 (supported since v11.x.x)
When a new version is released user should be able to define default values in his own environment and allow the use on an unsupported platform.
Describe the Solution You Would Like
Remove the failure on unsupported platforms.
Describe Alternatives You've Considered
Having separate branches of the control repo with different module versions. I prefer a single main branch for all environments though. Multiple control-repo branches lead to merge overhead and/or rotting branches.
Different module versions in different branches can also become an issue with inconsistent types.
As I laid out, this pattern is quire unique to this module. I would like this just to be removed. The compatibility is clearly documented in metadata.json and if I choose to ignore that I don't want some extra hoops to jump through.
Whine the Ais/version default mappings are handy,I agree with the need to be able to force a specific package/version. That will be used even if the OS/version hasn’t been mapped (and bypasses the “not supported” block). The user would then be responsible whether the module worked partially, or at all, but would mean users could keep using the module for new versions (eg: Ubuntu 24.04) before official support was added (and continue using the module in legacy environments if needed).
Use Case
Sometimes it happens that stuff runs on legacy platforms for reasons. The code in
https://github.com/puppetlabs/puppetlabs-java/blob/main/manifests/init.pp#L97-L106 prevents the use of the module on unsupported platforms. This pattern is quite unique to this module. For example it prevents the use of the same module on Debian 9 (supported until v10.x.x) and Debian 12 (supported since v11.x.x)
When a new version is released user should be able to define default values in his own environment and allow the use on an unsupported platform.
Describe the Solution You Would Like
Remove the failure on unsupported platforms.
Describe Alternatives You've Considered
Having separate branches of the control repo with different module versions. I prefer a single main branch for all environments though. Multiple control-repo branches lead to merge overhead and/or rotting branches.
Different module versions in different branches can also become an issue with inconsistent types.
Additional Context
https://puppetcommunity.slack.com/archives/CFD8Z9A4T/p1713871729247549
The text was updated successfully, but these errors were encountered: