Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS version check prevents usage on unsupported platforms #591

Open
TheMeier opened this issue May 3, 2024 · 3 comments
Open

OS version check prevents usage on unsupported platforms #591

TheMeier opened this issue May 3, 2024 · 3 comments

Comments

@TheMeier
Copy link

TheMeier commented May 3, 2024

Use Case

Sometimes it happens that stuff runs on legacy platforms for reasons. The code in
https://github.com/puppetlabs/puppetlabs-java/blob/main/manifests/init.pp#L97-L106 prevents the use of the module on unsupported platforms. This pattern is quite unique to this module. For example it prevents the use of the same module on Debian 9 (supported until v10.x.x) and Debian 12 (supported since v11.x.x)
When a new version is released user should be able to define default values in his own environment and allow the use on an unsupported platform.

Describe the Solution You Would Like

Remove the failure on unsupported platforms.

Describe Alternatives You've Considered

Having separate branches of the control repo with different module versions. I prefer a single main branch for all environments though. Multiple control-repo branches lead to merge overhead and/or rotting branches.
Different module versions in different branches can also become an issue with inconsistent types.

Additional Context

https://puppetcommunity.slack.com/archives/CFD8Z9A4T/p1713871729247549

@davidsandilands
Copy link
Member

Sorry for being late to this, do you think a simple override flag so user can choose to skip this check would be enough?

@TheMeier
Copy link
Author

As I laid out, this pattern is quire unique to this module. I would like this just to be removed. The compatibility is clearly documented in metadata.json and if I choose to ignore that I don't want some extra hoops to jump through.

@ogtool
Copy link

ogtool commented Sep 20, 2024

Whine the Ais/version default mappings are handy,I agree with the need to be able to force a specific package/version. That will be used even if the OS/version hasn’t been mapped (and bypasses the “not supported” block). The user would then be responsible whether the module worked partially, or at all, but would mean users could keep using the module for new versions (eg: Ubuntu 24.04) before official support was added (and continue using the module in legacy environments if needed).

CCM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants