PR comments resolved

puppetlabs · Sep 20, 2023 · 00a227b · 00a227b
1 parent be96ee8
commit 00a227b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/manifests/params.pp b/manifests/params.pp
@@ -485,7 +485,7 @@
   }
 
   ## Additional graceful failures
-  if $facts['os']['family'] == 'RedHat' and $facts['os']['release']['major'] == '4' and $facts['os']['name'] != 'Amazon' {
+  if $facts['os']['family'] == 'RedHat' and $facts['os']['release']['major'] < '7' and $facts['os']['name'] != 'Amazon' {
     fail("Unsupported platform: puppetlabs-${module_name} only supports RedHat 7.0 and beyond.")
   }
 }
diff --git a/spec/classes/mysql_backup_xtrabackup_spec.rb b/spec/classes/mysql_backup_xtrabackup_spec.rb
@@ -40,7 +40,7 @@ class { 'mysql::server': }
         package = if facts[:os]['family'] == 'RedHat'
                     if Puppet::Util::Package.versioncmp(facts[:os]['release']['major'], '8') >= 0
                       'percona-xtrabackup-24'
-                    elsif Puppet::Util::Package.versioncmp(facts[:os]['release']['major'], '7') >= 0
+                    else
                       'percona-xtrabackup'
                     end
                   elsif facts[:os]['name'] == 'Debian'
@@ -193,7 +193,7 @@ class { 'mysql::server': }
         package = if facts[:os]['family'] == 'RedHat'
                     if Puppet::Util::Package.versioncmp(facts[:os]['release']['major'], '8') >= 0
                       'percona-xtrabackup-24'
-                    elsif Puppet::Util::Package.versioncmp(facts[:os]['release']['major'], '7') >= 0
+                    else
                       'percona-xtrabackup'
                     end
                   elsif facts[:os]['name'] == 'Debian'