allow metacharacters * and ? in sql file path

[zivis]

Hi,

I had a problem with another module (sensson/puppet-powerdns)
which has given /usr/share/doc/pdns-backend-mysql-*.*.*/schema.mysql.sql as sql to mysql::db
this failed with file … is invalid. A valid file path is expected.

Are the metacharacters ? and * problematic in these paths and should I fix it else where or would it be okay to use these?

[CLAassistant]

All committers have signed the CLA.

[puppet-community-rangefinder]

mysql::db is a type

Breaking changes to this file WILL impact these 68 modules (exact match):

• treydock-xdmod
• mmitchell-puppetlabs_ironic
• puppetlabs-bacula
• infnpd-ocpattrauth
• cnwr-cacti
• lboynton-gitlab
• forj-openfire
• fiddyspence-zabbix
• binford2k-drupal
• alkivi-owncloud
• wyrie-snmptt
• eelcomaljaars-friendica
• qroac-isp3node
• monkygames-beansbooks
• martialblog-limesurvey
• samuelson-custom_webapp
• akisakye-matomo
• tscopp-jss
• hgkamath-owncloud
• brucem-ezpublish
• martasd-mediawiki
• stesie-gluon
• alisio-opensipscp
• othalla-nextcloud
• sgnl05-racktables
• hexmode-mediawiki
• ccaum-autoami
• rharrison-bacula
• alisio-opensips
• benjaminrobertson-observium
• leonardothibes-usvn
• desalvo-bacula
• firefield-firefield
• wyrie-nagiosql
• dsestero-sonarqube
• bodgit-wordpress
• mightp-librenms
• dmcnicks-sympa
• marcdeop-ratticdb
• aimonb-nexusis_gerrit
• cirrax-postfixadmin
• icann-opendnssec
• aimonb-nexusis_mediawiki
• autostructure-artifactory
• lsst-ccs_database
• sensson-powerdns
• oris-appserver
• fervid-artifactory
• openstack-monasca
• factorit-jasperreports_server
• SchnWalter-happydev
• geoffwilliams-r_profile
• blackknight36-bacula
• treydock-keycloak
• cirrax-roundcube
• mricon-bugzilla
• alkivi-zabbix
• bramwelt-patchwork
• shoekstra-owncloud
• jefferyb-kualicoeus
• ULHPC-slurm
• treydock-slurm
• razorsedge-cloudera
• maxadamo-galera_proxysql
• puppet-zabbix
• jsnshrmn-twlight
• wdijkerman-zabbix
• cesnet-site_hadoop

Breaking changes to this file MAY impact these 16 modules (near match):

• kclnmssys-sympa
• mwils-complete_wordpress
• devopera-domysqldb
• cesnet-oozie
• jtopjian-cubbystack
• tykeal-gerrit
• echoes-wrappers
• cesnet-hive
• soli-wrappers
• halyard-boxen
• rspiak-racktables
• icinga-icinga
• abaranov-sqlgrey
• lcgdm-lcgdm
• lcgdm-dmlite
• erwbgy-wso2

This module is declared in 140 of 580 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[BuJo]

Since sensson/puppet-powerdns@26ca5b6 this might not be necessary anymore.

However, it says it depends on the puppet mysql 15 (judging by the changes this might not be truly necessary), which in turn needs stdlib 9 which is backwards incompatible rendering many third/first-party modules unuseable. The new powerdns module might work, rendering the current PR moot?