Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysqlbackup: Reenable tests #1642

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

bastelfreak
Copy link
Collaborator

Previously the tests were only executed on mysql versions older than 5.7.0. This commit removes the contraint.

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@alexjfisher
Copy link
Collaborator

There's also this note in the README.

**Note:** The mysqlbackup.sh does not work and is not supported on MySQL 5.7 and greater.

But I don't know how accurate that is. Looks like there have been a number of updates to the script since then.

Previously the tests were only executed on mysql versions older than
5.7.0. This commit removes the contraint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants