Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Ripple effect #57

Open
danielchalmers opened this issue Apr 29, 2024 · 4 comments
Open

Proposal: Ripple effect #57

danielchalmers opened this issue Apr 29, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@danielchalmers
Copy link

A ripple effect for interactable components:

video2.mp4

It should originate from the pointer:

video3.mp4

It should start when the pointer is held and end when the pointer is released (with a minimum of about half a second or so):

video4.mp4

And it should be able to ripple multiple times at once:

video4.mp4
@codymullins codymullins added the enhancement New feature or request label Apr 29, 2024
@codymullins
Copy link
Contributor

I like it - we previously had a "jiggle" effect that had to be temporarily removed, we can probably look at how to enable both of these things with the theming or a PressedStyles parameter.

@codymullins
Copy link
Contributor

codymullins commented May 3, 2024

Re-added base for this functionality in 0ca0ffb

@codymullins codymullins added good first issue Good for newcomers help wanted Extra attention is needed labels May 3, 2024
@danielchalmers
Copy link
Author

Re-added base for this functionality in 0ca0ffb

@codymullins Cool! I see onmousedown, onmouseup, onclick (MouseEventArgs) - Does it work with touch? onpointerdown might work better 🤔

@codymullins
Copy link
Contributor

good call - I noticed touch wasn't working correctly when testing from my phone lasts night.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants