Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PVEngine.skip_step is not used #10

Open
kandersolar opened this issue Aug 14, 2023 · 0 comments
Open

PVEngine.skip_step is not used #10

kandersolar opened this issue Aug 14, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@kandersolar
Copy link
Member

Originally posted in SunPower/pvfactors#139:

PVEngine creates a mask indicating values that need not be considered in the calculation:

# Skip timesteps when:
# - solar zenith > 90, ie the sun is down
# - DNI or DHI is negative, which does not make sense
# - DNI and DHI are both zero
self.skip_step = (solar_zenith > 90) | (DNI < 0) | (DHI < 0) \
| ((DNI == 0) & (DHI == 0))

However, that mask is not actually used anywhere today. It used to be, but it looks like it stopped being used in #84 during the switch from iterative to vectorized code.

I think the underlying concept may still be useful even in the current vectorized approach, so I think it's probably worth seeing if we can start using it again somehow, otherwise it should just be deleted IMHO.

@kandersolar kandersolar added the bug Something isn't working label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant