Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages with route parameters break page registration. #33

Closed
oddvalue opened this issue Oct 13, 2023 · 0 comments · Fixed by #34
Closed

Pages with route parameters break page registration. #33

oddvalue opened this issue Oct 13, 2023 · 0 comments · Fixed by #34

Comments

@oddvalue
Copy link
Contributor

This has already been mentioned in #17 but we have a few pages within our application that have route parameters. One possible solution would be to check whether or not the page should register navigation in RegisterPages:

            if ($page::shouldRegisterNavigation() === false) {
                continue;
            }

If having pages that aren't in the navigation is an intended feature of this package then maybe that could be togglable? Or some way to excluded certain pages added?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant