Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BOT] Can't find checklist if there are too many comments in the PR #1940

Closed
EmilyBourne opened this issue Jul 22, 2024 · 1 comment · Fixed by #1949
Closed

[BOT] Can't find checklist if there are too many comments in the PR #1940

EmilyBourne opened this issue Jul 22, 2024 · 1 comment · Fixed by #1949
Labels
Bot bug

Comments

@EmilyBourne
Copy link
Member

Describe the bug

The bot only reads the first 100 comments when looking for a checklist. If the PR is not clean and the checklist has been requested late, this can lead to the checklist being lost.

To Reproduce

See pyccel#64

Expected behavior

This can be fixed by collecting all (multiple pages of) the comments on the issue instead of only the first 100
@EmilyBourne
Copy link
Member Author

cc: @smazouz42

EmilyBourne added a commit that referenced this issue Jul 26, 2024
@EmilyBourne
Read all comments in PR. Fixes #1940
5242070
@EmilyBourne EmilyBourne linked a pull request Jul 26, 2024 that will close this issue
Bot improvements #1949
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bot bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bot improvements pyccel/pyccel
1 participant
@EmilyBourne