Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong LRC calculation in ASCII MODE #125

Open
uaranguren opened this issue Dec 21, 2023 · 0 comments
Open

Wrong LRC calculation in ASCII MODE #125

uaranguren opened this issue Dec 21, 2023 · 0 comments

Comments

@uaranguren
Copy link

When trying to use ASCII mode, the LRC is not correctly calculated.

The function _calculate_lrc receives data in ASCII (not converted to hex). Then, it performs the correct operations but the input is incorrect. To solve this problem, _calculate_lrc shoult convert its input to hex using _hexencode. It could be also possible that the previous function (_embed_payload) performed this conversion before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@uaranguren