Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hole In One Improvements #309

Open
13 tasks
JoschD opened this issue Aug 1, 2021 · 0 comments
Open
13 tasks

Hole In One Improvements #309

JoschD opened this issue Aug 1, 2021 · 0 comments
Labels
Domain: GUI Closely related to GUI and/or needs GUI changes as well. Type: Documentation Improvements, updates and fixes to the documentation. Type: Feature A (suggetion for a) new feature or enhancement in functionality.

Comments

@JoschD
Copy link
Member

JoschD commented Aug 1, 2021

Some things that came up when trying to use Hole In One:

  • Probably we should require setting the turns (or at least log a warning if not set) as this should usually be done.
  • Log a warning if turns are not given in ascending order (or throw error)
  • Possible bug in "is_free_kick" as written out into the ini. We thought it was checked, but in the ini it was False. To be checked.
  • Free kick does not seem to check if nat-tunes are present

Documentation Improvements

  • Docstring is not updated. There are missing parameters and outdated info.
  • More details on SVD cut
  • more details on how the svd dominance limit works
  • Explain the different TbT input types
  • Explain the "input unit"
    • When is the data converted (should be: either convert via tbt converter and then hio should be as input in m. Or do not convert beforehand and give the correct unit to hio)
    • All cuts should be in meters (I think)

For the GUI side:

  • is "keep dominant BPMs" still a thing?
  • Sync new HiO parameters (and doc) to GUI settings.
@JoschD JoschD added Type: Feature A (suggetion for a) new feature or enhancement in functionality. Domain: GUI Closely related to GUI and/or needs GUI changes as well. labels Aug 1, 2021
@fsoubelet fsoubelet added the Type: Documentation Improvements, updates and fixes to the documentation. label Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Domain: GUI Closely related to GUI and/or needs GUI changes as well. Type: Documentation Improvements, updates and fixes to the documentation. Type: Feature A (suggetion for a) new feature or enhancement in functionality.
Projects
None yet
Development

No branches or pull requests

2 participants