You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One can give any input parameters to hole_in_one (entrypoint) without the parser complaining, because all unknown parameters are dumped into "rest".
At least when running without optics analysis.
There is actually a parameter singval in the harpy tests that should be called sing_val, but it's just never used (luckily in the test it has the same value as the default, so no harm done).
Steps to Reproduce
No response
Relevant output
No response
Possible Fix Implementation
_get_suboptions should have some checks if there is still parameters in rest if they are not needed.
The text was updated successfully, but these errors were encountered:
Documentation
Operating System
Any
Python Version
Any
Package Version
0.5.0
Bug Description
One can give any input parameters to hole_in_one (entrypoint) without the parser complaining, because all unknown parameters are dumped into "rest".
At least when running without optics analysis.
There is actually a parameter
singval
in the harpy tests that should be calledsing_val
, but it's just never used (luckily in the test it has the same value as the default, so no harm done).Steps to Reproduce
No response
Relevant output
No response
Possible Fix Implementation
_get_suboptions
should have some checks if there is still parameters inrest
if they are not needed.The text was updated successfully, but these errors were encountered: