Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Hole in One Options not really checked #388

Open
1 task done
JoschD opened this issue Aug 31, 2022 · 0 comments
Open
1 task done

[Bug]: Hole in One Options not really checked #388

JoschD opened this issue Aug 31, 2022 · 0 comments
Labels
Type: Bug Something isn't working as it should.

Comments

@JoschD
Copy link
Member

JoschD commented Aug 31, 2022

Documentation

  • Yes

Operating System

Any

Python Version

Any

Package Version

0.5.0

Bug Description

One can give any input parameters to hole_in_one (entrypoint) without the parser complaining, because all unknown parameters are dumped into "rest".
At least when running without optics analysis.
There is actually a parameter singval in the harpy tests that should be called sing_val, but it's just never used (luckily in the test it has the same value as the default, so no harm done).

Steps to Reproduce

No response

Relevant output

No response

Possible Fix Implementation

_get_suboptions should have some checks if there is still parameters in rest if they are not needed.

@JoschD JoschD added the Type: Bug Something isn't working as it should. label Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as it should.
Projects
None yet
Development

No branches or pull requests

1 participant