Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Output the complex frequency spectrum for harpy #424

Open
Mael-Le-Garrec opened this issue Jul 27, 2023 · 2 comments
Open
Labels
Type: Feature A (suggetion for a) new feature or enhancement in functionality.

Comments

@Mael-Le-Garrec
Copy link
Contributor

Feature Description

Only the real part of the frequency spectrum is written to the lin files when doing a frequency analysis.

For example, the columns AMP05 and AMP0_5, for the lines 5Qy and -5Qy have the same amplitude.
This makes differentiating between RDTs contributing to those two lines impossible.

Possible Implementation

I haven't checked the code, I do not know how feasible this is.

@Mael-Le-Garrec Mael-Le-Garrec added the Type: Feature A (suggetion for a) new feature or enhancement in functionality. label Jul 27, 2023
@JoschD
Copy link
Member

JoschD commented Mar 13, 2024

@Mael-Le-Garrec do you mean in the lin-files? You have AMP, PHASE and FREQ

@JoschD
Copy link
Member

JoschD commented Mar 13, 2024

if you want phases for all lines, it should be

tfs.write(f"{output_path_without_suffix}{FILE_AMPS_EXT.format(plane=plane.lower())}", spectra["COEFFS"].apply(np.angle).T)

in

def _write_spectrum(output_path_without_suffix, plane, spectra):

To check: maybe you need to divide by 2 pi and maybe you need to sync the phases to the first BPM, see

def _sync_phase(lin_frame, plane):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature A (suggetion for a) new feature or enhancement in functionality.
Projects
None yet
Development

No branches or pull requests

2 participants