Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Accelerator Class and Model Creation #469

Open
JoschD opened this issue Oct 31, 2024 · 0 comments
Open

Separate Accelerator Class and Model Creation #469

JoschD opened this issue Oct 31, 2024 · 0 comments
Assignees
Labels
Estimate: Complicated Might need some major overhaul of the code. Priority: Low Work on this if you have some spare time. Type: Maintenance Improvements in the code, that are not necessarily visible in functionality.

Comments

@JoschD
Copy link
Member

JoschD commented Oct 31, 2024

Content

There are a lot of functions in the accelerator class by now, that are only used for model creation.
As we also have individual model creators per accelerator, we should actually move this functionality from the accelerator class into model creation, hopefully decreasing coherence, making the code more readable and enabling easier adding of new accelerators,

The model creators would then get the specific (!) accelerator class as init-parameter and attach it to themselves,
using its parameters to e.g. create madx code etc.

The disadvantage is, that accelerator class and model creator class will have to be synced upon changes, but I don't think that can be avoided. And I hope that they are fairly static anyway.

Not an urgent task, but I think it would improve the code a lot - especially as model creation is one of the most convoluted codes in the repo.

Open for suggestions.

@JoschD JoschD added Priority: Low Work on this if you have some spare time. Type: Maintenance Improvements in the code, that are not necessarily visible in functionality. Estimate: Complicated Might need some major overhaul of the code. labels Oct 31, 2024
@JoschD JoschD self-assigned this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Estimate: Complicated Might need some major overhaul of the code. Priority: Low Work on this if you have some spare time. Type: Maintenance Improvements in the code, that are not necessarily visible in functionality.
Projects
None yet
Development

No branches or pull requests

1 participant