[Bug]: Beam direction possibly wrong for Beam 4/Beam 2 tracked backwards

[JoschD]

Bug Description

The opposite_direction flag is only used in harpy, but opposite direction is assumed later on in the optics analysis for Beam 2. This is fine for measurement data, but when working with tracking data model and turn-by-turn data can be in the same direction, even for Beam 2. This is not taken into account (in the accelerator class it is always set to -1).

Steps to Reproduce

Run optics analysis with Beam 4 tbt and model.

Possible Fix Implementation

Make opposite_direction an LHC accelerator-class parameter?

Also needs to be propagated then to the GUI.

[JoschD]

@Mael-Le-Garrec you have encountered this before, right? Any input?