Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GNU make dependency from postinstall #38

Open
exsilium opened this issue Dec 6, 2017 · 2 comments
Open

Remove GNU make dependency from postinstall #38

exsilium opened this issue Dec 6, 2017 · 2 comments

Comments

@exsilium
Copy link
Collaborator

exsilium commented Dec 6, 2017

As of moving to node-pty, the Windows native build of Cloud9v2 has become a low hanging fruit. Altought the npm i dependency installations are carried out successfully, the last step during postinstall fails due to reliance on GNU make. The Makefile targets are actually using simple unix shell commands.

Proposal is to migrate the required installation Makefile steps to build/postinstall.js and use shelljs commands as platform agnostic substitute.

@sr229
Copy link

sr229 commented Oct 20, 2018

We can try Grunt steps in place instead.

@exsilium
Copy link
Collaborator Author

Definitely grunt or gulp would be an option as a full featured task runners. I'm still conflicted about adding them as a dependency however just to copy some files. We'll see how this works out...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants