Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement deserialize for HSGP classes #1339

Open
wd60622 opened this issue Jan 4, 2025 · 0 comments
Open

Implement deserialize for HSGP classes #1339

wd60622 opened this issue Jan 4, 2025 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package TVPs Related to time varying parameters

Comments

@wd60622
Copy link
Contributor

wd60622 commented Jan 4, 2025

The HSGP classes are not supported in the deserialize function. They do have the to/from_dict methods but that structure might want to be replaced to a format that is more similar to the fourier classes. Reference:

def to_dict(self) -> dict[str, Any]:
"""Serialize the Fourier seasonality.
Returns
-------
dict[str, Any]
Serialized Fourier seasonality
"""
return {
"class": self.__class__.__name__,
"data": self.model_dump(mode="json"),
}

This PR #1315 would be a good reference for how to implement this.

@wd60622 wd60622 added enhancement New feature or request good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package TVPs Related to time varying parameters and removed Needs Triage labels Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers . Doesn't require extensive knowledge of the repo and package TVPs Related to time varying parameters
Projects
None yet
Development

No branches or pull requests

1 participant