You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi!
What is your opinion on an after-build section feature, similar to before-build?
One usecase that I have is for linux builds (which use docker image). before-build is used to properly setup ccache cache directory, like here in MLIR Python bindings nightly wheels. It installs ccache inside the docker image and moves external cache directory into the container (This approach is explained in #1030).
But then when we want to persist the cache after the build finishes user needs a separate GitHub action step to move new cache out of the docker image: link.
I think that managing cache could be done in before-build and after-build sections by running proper sh files, instead of relying on before-build script and a separate GitHub action step. This is not only more coherent but also allows user to reproduce the build process locally.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hi!
What is your opinion on an
after-build
section feature, similar tobefore-build
?One usecase that I have is for linux builds (which use docker image).
before-build
is used to properly setupccache
cache directory, like here in MLIR Python bindings nightly wheels. It installsccache
inside the docker image and moves external cache directory into the container (This approach is explained in #1030).But then when we want to persist the cache after the build finishes user needs a separate GitHub action step to move new cache out of the docker image: link.
I think that managing cache could be done in
before-build
andafter-build
sections by running proper sh files, instead of relying onbefore-build
script and a separate GitHub action step. This is not only more coherent but also allows user to reproduce the build process locally.WDYT? Would you accept
after-build
section?Beta Was this translation helpful? Give feedback.
All reactions