-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default image away from manylinux2014 #1772
Comments
And also, although this is a separate issue, decide on a timeline for dropping support for |
FYI, manylinux1 and manylinux2010 were supported well past CentOS EoL, in fact manylinux1 is still receiving automated updates and is still supported in cibuildwheel (CentOS 5). 20% of systems cannot support manylinux_2_28 (https://mayeut.github.io/manylinux-timeline/), based solely on the GLIBC version (you also need a recent pip version, which might limit it further). 70% of projects still distribute manylinux2014 wheels. So while this might change, I don't think it's likely to until after the EoL deadline. (That might help it start to change). |
We could also do it conditionally, based on Python version. So for example, practically all Python 3.12 consumers support glibc 2.31 or higher. Almost all Python 3.11 consumers support 2.28 or higher. So you could end up with something like:
Of course this needs to be properly announced, and maybe some policy for instated to update those numbers. |
Hmm..! Nice idea, downside would be that it is a bit wasteful in time and bandwidth, as a default. Much of the time of a build is downloading the container, plus, some users do heavy stuff in |
a great reference here is @mayeut's manylinux timeline |
As @joerick said, it's likely just a waste of resources to change the default conditionally on the python version and, users can already do that if they want(/need) to using overrides. With the current stats for non-EOL python versions, I'd say a good time to change the default could be after AmazonLinux 2 EOL (2025-06-30, I think that's most of GLIBC 2.26 downloads) or Python 3.9 EOL (2025-10-31). |
There are no images for 2.26. The next supported image is 2.28 hence the proposition in #1772 (comment) |
since centos7 is EOL, and it's mirrors now broken we are switching to newer manylinux version Ref: pypa/cibuildwheel#1772
since centos7 is EOL, and it's mirrors now broken we are switching to newer manylinux version Ref: pypa/cibuildwheel#1772 Ref: pypa/manylinux#1641
since centos7 is EOL, and it's mirrors now broken we are switching to newer manylinux version Ref: pypa/cibuildwheel#1772 Ref: pypa/manylinux#1641
since centos7 is EOL, and it's mirrors now broken we are switching to newer manylinux version Ref: pypa/cibuildwheel#1772 Ref: pypa/manylinux#1641
since centos7 is EOL, and it's mirrors now broken we are switching to newer manylinux version Ref: pypa/cibuildwheel#1772 Ref: pypa/manylinux#1641
since centos7 is EOL, and it's mirrors now broken we are switching to newer manylinux version Ref: pypa/cibuildwheel#1772 Ref: pypa/manylinux#1641
Support has risen to 92.8% according to the manylinux timeline. According to glibc versions the distro that don't support glibc 2.28 is mainly Amazon Linux 2, which I think they can handle (and a newer Amazon Linux 2023 image has been available for a while). Especially with CentOS 7 now being end of life, it might be time to update the default to Edit: You can also see: |
I opened a PR to move the default: #1988. |
The last statement on the matter was:
I think it would be good to get agreement or at least one maintainer on board before just going ahead and making the change. Another option, by the way, is to make the default arch-specific, and "special" archs could default to 2_28, as 2014 doesn't work as well for special archs. Moving away from 2014 will be quite disruptive as it has to be done on lower level dependencies first. For example, if numpy were to go 2_28, then every package using it to build would start either building numpy from scratch, taking much longer, or would start failing if it's not buildable. Maybe making this a recommendation for a while, or setting a change-over date, etc. would be a better approach? Also, previous versions of manylinux have gone 4+ years past EoL of the distro they were based on. |
Thanks for your insights. I also openend the PR to get some insights in if there are any complications implementation wise (such as the
I like the idea, but I'm curious what would your exact recommendation be? Asking repos to set specific manylinux versions, instead of pointing to the default one? That would make the point of a "default" manylinux version a bit mood right? Another idea I have right now is to add a flag First we could just add it, then we could update it to throw a warning that's soon changing, and then we can flip the default value. Another option is that in theory we could also build both Anyway, this will hurt in some way anyway. And currently it's also already hurting repos, by CentOS 7 being EOL (also see the motivation in the PR). |
A while ago I experimented with using Besides that, mypyc/mypy_mypyc-wheels#81 |
Building two wheels by default is out. Packages can fairly easily do that if they want (I did it for manylinux1 and 2010 for a long time for boost-histogram), and we could add docs on it, but we shouldn't double the space and time and drastically complicate the internals to build multiple wheels from a single identifier. This would also run before-all twice, and it would need new ways to customize just one of the two linux builds (since the images are not identical). Auditwheel will add a lower tag if you aren't using any symbols from a newer GCC, that's why you got the 2014 tag too, I believe. It won't always happen for all projects.
I don't like the idea of adding a flag. Someone can always just set these to what they want, and the flag would eventually change meaning for the next bump, etc. An alternative to this would be maybe to push harder for projects to always specify this so they don't depend on our default? That's really quite similar to my previous suggestion of suggesting 2_28 as a recommendation in the docs.
We've been solving the issues by adjusting mirrors. I expect it will (has?) stabilize. Manylinux1 and 2010 were maintained years after EoL. |
PS: I'm carefully not giving an opinions about the bump date, just pointing out the only opinions I've seen so far are 2025-06-30 and 2025-10-31, etc. I do think it makes sense to set a date and list it in our docs as a change over date. Packages are strongly recommended to pin to minor versions or better, so making a default change is as safe and painless as it reasonably can be. |
Thanks for your replies and the insight! One thing I’m thinking of, that if you are using a default most of the time you’re okay bit it being updated once in a while, and you might even expect it. That’s why people use Python Like you pointed out, the same goes for pinning the minor cibuildwheel version. For most projects, friendly PRs would be updated. I’m curious about a few other things. First, do you see an elegant way to throw an info / warning message that we changing the default? Second, I initially read this wrong:
I read it as Python 3.8 EOL, which is 2019-10-14. Six weeks seems like a fine timeframe for an announcement and info message. Finally, from a default I would say it’s broadly supported, not based on a end-of-life host. For me it seems perfectly fine to keep it as a supported option, but it just might be nice to move the default to a version that’s fully supported. |
Regarding the exact date, I'm happy to defer to @mayeut who is a lot closer to this part of Python packaging. His previous statement was:
If there's a toss-up, my bias would be to go for the earlier date of the two. I'm happy for him to decide though.
Big fan of this idea. We can also mention it in the next release notes. |
I just created pypa/manylinux#1671 to drop python 3.6 & 3.7 from the manylinux images (mostly in order to add 3.14 without image size growing or build times getting much longer). 3.6 will be dropped for sure. Depending on feedback for 3.7 but given more than 50% of downloads are from AmazonLinux 2 or so it seems, it is reasonable to drop it at that time IMHO. I think it would make sense to change the default at the same time (which is just over 1 month before AmazonLinux 2 EOL). |
Thanks for your perspective. It feels a bit weird to keep the default version hosted on end-of-life OSes, because one single cloud OS version isn't compatible. Since it's all cloud usage, they can all relatively easily migrate to the 2023 version of that OS. Or just set So I'm not saying that we shouldn't support |
Description
CentOS 7 (on which
manylinux2014
is based) goes end-of-life in only a few months (June) - as such it's probably a good idea to look for a new default base image. Almost certainlymanylinux_2_28
.Build log
No response
CI config
No response
The text was updated successfully, but these errors were encountered: