-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reword and migrate editable errors to rich format #12464
Conversation
A general question I have is whether to let rich automatically highlight numbers, links, paths, etc. It's distracting noise for most requirements, but it could be nicer for URLs. |
For now, wrapping these in |
Actually this needs some work because (invalid) editable requirements can be created as part of userflows that don't involve installation, like |
The error can raised by pip wheel (yea, I know) so it's best to avoid mentioning installation.
The invalid editable error may still be confusing in the context of |
@ichard26 Why is this PR marked as a draft? |
See #12811 which has the conflicts fixed + some further improvements! |
Before:
After:
Towards #10421. ✨