Replies: 2 comments 1 reply
-
|
I found that patching this line to allow all python versions that we support I am not sure what side-effect edge cases might be reported for doing that, but it passed the CI and extra testing. If anyone has additional insights on this edge case, would love to hear about it. Seems more related to |
Beta Was this translation helpful? Give feedback.
-
|
Hi @matteius, that seems like a tricky problem... Is there anyway we can reproduce this just in terms of a regular virtual environment and pip (without I tried the following in a # docker run --rm -it python:3.8 bash
cd /tmp/
python -m venv .venv
.venv/bin/python -m pip install 'setuptools==63.4.1'
cat <<EOF > requirements.txt
setuptools==65.1.0; python_version >= '3.7' \
--hash=sha256:d2e010624c781b26ad6629a8de9832327cf853dea93894487979e55f9ad06857 \
--hash=sha256:10602cd0a6f5feab6656e9587f9075292ab777c5200f3bf00293ecd23d9f2788
EOF
.venv/bin/python -m pip install -r requirements.txtBut everything seems to work fine. I am curious about the error Let's consider the following scenarios under the assumption that
I am trying to wrap my head around this topic... Is there any chance the |
Beta Was this translation helpful? Give feedback.
-
|
@abravalheri In the examples I have seen it is always trying to install a wheel. However its in the context of a virtualenv that has setuptools installed when the virtualenv is created. It seems it moves the location of setuptools and then cannot find it during the install, so I feel like this falls into your scenario number 1 but with the caveat that setuptools is likely on disk. Its possible that pipenv already imported EDIT: the thing that fixes it was allowing the sysconfig usage from patching pip for all versions of supported python >= 3.7 -- but I do wonder about possible side effects of this change on older systems that may not have patched sysconfig properly. I am not well versed in this topic, but are you saying that if setuptools were in memory/on disc that it behaves differently than you describe in scenario number 1? |
Beta Was this translation helpful? Give feedback.
-
This is a request for support, I opened a pip issue (pypa/pip#11389) related but I am not sure if its pip, setuptools, but it definitely is affecting the ability of pipenv to upgrade setuptools to a specific version on python < 3.10
Basically, it would appear that pip removes setuptools and then importlib is unable to find it when trying to install the new setuptools and so it rolls back.
Here is the test runner on the branch where I try to allow setuptools to be installable again from the lock file: https://github.com/pypa/pipenv/runs/7909759909?check_suite_focus=true
Any ideas from the setuptools side that might be helpful for us to move forward?
Beta Was this translation helpful? Give feedback.
All reactions